Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdm: deprecate #135151

Merged
merged 1 commit into from
Jun 27, 2023
Merged

gdm: deprecate #135151

merged 1 commit into from
Jun 27, 2023

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Last tag was 2016 and no reponse from sparrc/gdm#29

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Jun 27, 2023
@branchvincent branchvincent added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jun 27, 2023
@chenrui333
Copy link
Member

seems building/testing fine with go1.20.5??

@branchvincent
Copy link
Member Author

that's true, I was just going through the GOPATH epic #47627 and deprecating formulae that haven't seen a commit/release in years and didn't respond to our request for using modules

iMichka
iMichka approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.
Download stats look empty too:
==> Analytics
install: 0 (30 days), 0 (90 days), 0 (365 days)
install-on-request: 0 (30 days), 0 (90 days), 0 (365 days)
build-error: 0 (30 days)

@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 27, 2023
Merged via the queue into Homebrew:master with commit b406ef2 Jun 27, 2023
@branchvincent branchvincent deleted the gdm branch June 28, 2023 01:48
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iMichka iMichka iMichka approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@branchvincent @chenrui333 @iMichka @BrewTestBot